-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort realms alphabetically in dropdown on signup page #1549
base: dev
Are you sure you want to change the base?
Conversation
There are some changes to |
I noticed that getRealms is also being called in the report-editor page and the users page. In the users table, the user can sort by any column of the table, so the order it gets the realms is unimportant. On the report-editor page, the only place where it uses the realms is if the user is a super-admin, in which case it gives an option to replace the user who created the report with any other user in any realm, using a dropdown that groups users by realm. It doesn't seem to be sorting the groups alphabetically, but the code is a little over my head, and it seems like a very niche use-case. Do you want me to try to address that? |
I think this PR is good as-is, thanks for making the suggested change! |
closes #1548
Title says it all.